Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/editpage/TextConflictHelper.php

Summary

Maintainability
D
2 days
Test Coverage

Method incrementConflictStats has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function incrementConflictStats( User $user = null ) {
        $namespace = 'n/a';
        $userBucket = 'n/a';
        $statsdMetrics = [ 'edit.failures.conflict' ];
Severity: Minor
Found in includes/editpage/TextConflictHelper.php - About 1 hr to fix

    Method incrementResolvedStats has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function incrementResolvedStats( User $user = null ) {
        $namespace = 'n/a';
        $userBucket = 'n/a';
        $statsdMetrics = [ 'edit.failures.conflict.resolved' ];
    Severity: Minor
    Found in includes/editpage/TextConflictHelper.php - About 1 hr to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Title $title, OutputPage $out, $stats, $submitLabel,
        IContentHandlerFactory $contentHandlerFactory
      Severity: Minor
      Found in includes/editpage/TextConflictHelper.php - About 35 mins to fix

        Function incrementConflictStats has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function incrementConflictStats( User $user = null ) {
        $namespace = 'n/a';
        $userBucket = 'n/a';
        $statsdMetrics = [ 'edit.failures.conflict' ];
        Severity: Minor
        Found in includes/editpage/TextConflictHelper.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function incrementResolvedStats has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function incrementResolvedStats( User $user = null ) {
        $namespace = 'n/a';
        $userBucket = 'n/a';
        $statsdMetrics = [ 'edit.failures.conflict.resolved' ];
        Severity: Minor
        Found in includes/editpage/TextConflictHelper.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return 'under11';
        Severity: Major
        Found in includes/editpage/TextConflictHelper.php - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function incrementResolvedStats( User $user = null ) {
        $namespace = 'n/a';
        $userBucket = 'n/a';
        $statsdMetrics = [ 'edit.failures.conflict.resolved' ];
          Severity: Major
          Found in includes/editpage/TextConflictHelper.php and 1 other location - About 7 hrs to fix
          includes/editpage/TextConflictHelper.php on lines 139..171

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 230.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function incrementConflictStats( User $user = null ) {
        $namespace = 'n/a';
        $userBucket = 'n/a';
        $statsdMetrics = [ 'edit.failures.conflict' ];
          Severity: Major
          Found in includes/editpage/TextConflictHelper.php and 1 other location - About 7 hrs to fix
          includes/editpage/TextConflictHelper.php on lines 177..211

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 230.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status