Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/exception/MWExceptionRenderer.php

Summary

Maintainability
C
1 day
Test Coverage

Function output has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public static function output( Throwable $e, $mode, Throwable $eNew = null ) {
        $showExceptionDetails = self::shouldShowExceptionDetails();
        if ( $e instanceof RequestTimeoutException && headers_sent() ) {
            // Excimer's flag check happens on function return, so, a timeout
            // can be thrown after exiting, say, `doPostOutputShutdown`, where
Severity: Minor
Found in includes/exception/MWExceptionRenderer.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MWExceptionRenderer.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/exception/MWExceptionRenderer.php - About 2 hrs to fix

    Method output has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function output( Throwable $e, $mode, Throwable $eNew = null ) {
        $showExceptionDetails = self::shouldShowExceptionDetails();
        if ( $e instanceof RequestTimeoutException && headers_sent() ) {
            // Excimer's flag check happens on function return, so, a timeout
            // can be thrown after exiting, say, `doPostOutputShutdown`, where
    Severity: Major
    Found in includes/exception/MWExceptionRenderer.php - About 2 hrs to fix

      Method reportOutageHTML has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static function reportOutageHTML( Throwable $e ) {
        $mainConfig = MediaWikiServices::getInstance()->getMainConfig();
        $showExceptionDetails = $mainConfig->get( MainConfigNames::ShowExceptionDetails );
        $showHostnames = $mainConfig->get( MainConfigNames::ShowHostnames );
        $sorry = htmlspecialchars( self::msg(
      Severity: Minor
      Found in includes/exception/MWExceptionRenderer.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status