Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/filebackend/FileBackendGroup.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method __construct has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(
        ServiceOptions $options,
        ReadOnlyMode $readOnlyMode,
        BagOStuff $srvCache,
        WANObjectCache $wanCache,
Severity: Minor
Found in includes/filebackend/FileBackendGroup.php - About 1 hr to fix

    Function get has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get( $name ) {
        // Lazy-load the actual backend instance
        if ( !isset( $this->backends[$name]['instance'] ) ) {
            $config = $this->config( $name );
    Severity: Minor
    Found in includes/filebackend/FileBackendGroup.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method config has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function config( $name ) {
        if ( !isset( $this->backends[$name] ) ) {
            throw new InvalidArgumentException( "No backend defined with the name '$name'." );
        }
    Severity: Minor
    Found in includes/filebackend/FileBackendGroup.php - About 1 hr to fix

      Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ServiceOptions $options,
        ReadOnlyMode $readOnlyMode,
        BagOStuff $srvCache,
        WANObjectCache $wanCache,
        MimeAnalyzer $mimeAnalyzer,
      Severity: Major
      Found in includes/filebackend/FileBackendGroup.php - About 1 hr to fix

        Function register has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function register( array $configs, $readOnlyReason = null ) {
        foreach ( $configs as $config ) {
            if ( !isset( $config['name'] ) ) {
                throw new InvalidArgumentException( "Cannot register a backend with no name." );
            }
        Severity: Minor
        Found in includes/filebackend/FileBackendGroup.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status