wikimedia/mediawiki-core

View on GitHub
includes/filerepo/LocalRepo.php

Summary

Maintainability
D
3 days
Test Coverage

Function findFiles has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    public function findFiles( array $items, $flags = 0 ) {
        $finalFiles = []; // map of (DB key => corresponding File) for matches

        $searchSet = []; // map of (normalized DB key => search params)
        foreach ( $items as $item ) {
Severity: Minor
Found in includes/filerepo/LocalRepo.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File LocalRepo.php has 413 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/filerepo/LocalRepo.php - About 5 hrs to fix

    LocalRepo has 32 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class LocalRepo extends FileRepo {
        /** @var callable */
        protected $fileFactory = [ LocalFile::class, 'newFromTitle' ];
        /** @var callable */
        protected $fileFactoryKey = [ LocalFile::class, 'newFromKey' ];
    Severity: Minor
    Found in includes/filerepo/LocalRepo.php - About 4 hrs to fix

      Method findFiles has 99 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function findFiles( array $items, $flags = 0 ) {
              $finalFiles = []; // map of (DB key => corresponding File) for matches
      
              $searchSet = []; // map of (normalized DB key => search params)
              foreach ( $items as $item ) {
      Severity: Major
      Found in includes/filerepo/LocalRepo.php - About 3 hrs to fix

        Method checkRedirect has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function checkRedirect( $title ) {
                $title = File::normalizeTitle( $title, 'exception' );
        
                $memcKey = $this->getSharedCacheKey( 'file-redirect', md5( $title->getDBkey() ) );
                if ( $memcKey === false ) {
        Severity: Minor
        Found in includes/filerepo/LocalRepo.php - About 1 hr to fix

          Method cleanupDeletedBatch has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function cleanupDeletedBatch( array $storageKeys ) {
                  if ( $this->hasSha1Storage() ) {
                      wfDebug( __METHOD__ . ": skipped because storage uses sha1 paths" );
                      return Status::newGood();
                  }
          Severity: Minor
          Found in includes/filerepo/LocalRepo.php - About 1 hr to fix

            Function cleanupDeletedBatch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function cleanupDeletedBatch( array $storageKeys ) {
                    if ( $this->hasSha1Storage() ) {
                        wfDebug( __METHOD__ . ": skipped because storage uses sha1 paths" );
                        return Status::newGood();
                    }
            Severity: Minor
            Found in includes/filerepo/LocalRepo.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method publish has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $src,
                    $dstRel,
                    $archiveRel,
                    $flags = 0,
                    array $options = []
            Severity: Minor
            Found in includes/filerepo/LocalRepo.php - About 35 mins to fix

              There are no issues that match your filters.

              Category
              Status