Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/filerepo/file/LocalFileDeleteBatch.php

Summary

Maintainability
D
1 day
Test Coverage

Method doDBInserts has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function doDBInserts() {
        $now = time();
        $dbw = $this->file->repo->getPrimaryDB();

        $commentStore = MediaWikiServices::getInstance()->getCommentStore();
Severity: Major
Found in includes/filerepo/file/LocalFileDeleteBatch.php - About 3 hrs to fix

    File LocalFileDeleteBatch.php has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/filerepo/file/LocalFileDeleteBatch.php - About 2 hrs to fix

      Function getHashes has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getHashes( StatusValue $status ): array {
        $hashes = [];
        [ $oldRels, $deleteCurrent ] = $this->getOldRels();

        if ( $deleteCurrent ) {
      Severity: Minor
      Found in includes/filerepo/file/LocalFileDeleteBatch.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getHashes has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getHashes( StatusValue $status ): array {
        $hashes = [];
        [ $oldRels, $deleteCurrent ] = $this->getOldRels();

        if ( $deleteCurrent ) {
      Severity: Major
      Found in includes/filerepo/file/LocalFileDeleteBatch.php - About 2 hrs to fix

        Method execute has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function execute() {
        $repo = $this->file->getRepo();
        $lockStatus = $this->file->acquireFileLock();
        if ( !$lockStatus->isOK() ) {
            return $lockStatus;
        Severity: Minor
        Found in includes/filerepo/file/LocalFileDeleteBatch.php - About 1 hr to fix

          Function execute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function execute() {
        $repo = $this->file->getRepo();
        $lockStatus = $this->file->acquireFileLock();
        if ( !$lockStatus->isOK() ) {
            return $lockStatus;
          Severity: Minor
          Found in includes/filerepo/file/LocalFileDeleteBatch.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function doDBInserts has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function doDBInserts() {
        $now = time();
        $dbw = $this->file->repo->getPrimaryDB();

        $commentStore = MediaWikiServices::getInstance()->getCommentStore();
          Severity: Minor
          Found in includes/filerepo/file/LocalFileDeleteBatch.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status