Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/filerepo/file/LocalFileRestoreBatch.php

Summary

Maintainability
D
2 days
Test Coverage

Method execute has 196 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        /** @var Language $wgLang */
        global $wgLang;

        $repo = $this->file->getRepo();
Severity: Major
Found in includes/filerepo/file/LocalFileRestoreBatch.php - About 7 hrs to fix

    Function execute has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
    Open

        public function execute() {
        /** @var Language $wgLang */
        global $wgLang;

        $repo = $this->file->getRepo();
    Severity: Minor
    Found in includes/filerepo/file/LocalFileRestoreBatch.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File LocalFileRestoreBatch.php has 277 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/filerepo/file/LocalFileRestoreBatch.php - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

                  if ( $row->fa_major_mime === null || $row->fa_major_mime == 'unknown'
                || $row->fa_minor_mime === null || $row->fa_minor_mime == 'unknown'
                || $row->fa_media_type === null || $row->fa_media_type == 'UNKNOWN'
                || $row->fa_metadata === null
            ) {
      Severity: Major
      Found in includes/filerepo/file/LocalFileRestoreBatch.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                        return $status;
        Severity: Major
        Found in includes/filerepo/file/LocalFileRestoreBatch.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $status;
          Severity: Major
          Found in includes/filerepo/file/LocalFileRestoreBatch.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status