Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/filerepo/file/OldLocalFile.php

Summary

Maintainability
C
1 day
Test Coverage

OldLocalFile has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class OldLocalFile extends LocalFile {
    /** @var string|int Timestamp */
    protected $requestedTime;

    /** @var string Archive name */
Severity: Minor
Found in includes/filerepo/file/OldLocalFile.php - About 2 hrs to fix

    Method recordOldUpload has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function recordOldUpload( $srcPath, $archiveName, $timestamp, $comment, $user ) {
        $dbw = $this->repo->getPrimaryDB();

        $services = MediaWikiServices::getInstance();
        $mwProps = new MWFileProps( $services->getMimeAnalyzer() );
    Severity: Minor
    Found in includes/filerepo/file/OldLocalFile.php - About 1 hr to fix

      Method upgradeRow has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function upgradeRow() {
        $this->loadFromFile();

        # Don't destroy file info of missing files
        if ( !$this->fileExists ) {
      Severity: Minor
      Found in includes/filerepo/file/OldLocalFile.php - About 1 hr to fix

        Method recordOldUpload has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected function recordOldUpload( $srcPath, $archiveName, $timestamp, $comment, $user ) {
        Severity: Minor
        Found in includes/filerepo/file/OldLocalFile.php - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static function newFromKey( $sha1, $repo, $timestamp = false ) {
        $dbr = $repo->getReplicaDB();
        $queryBuilder = FileSelectQueryBuilder::newForOldFile( $dbr );

        $queryBuilder->where( [ 'oi_sha1' => $sha1 ] );
          Severity: Major
          Found in includes/filerepo/file/OldLocalFile.php and 1 other location - About 2 hrs to fix
          includes/filerepo/file/LocalFile.php on lines 243..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 129.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status