Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/gallery/TraditionalImageGallery.php

Summary

Maintainability
D
2 days
Test Coverage

Function toHTML has a Cognitive Complexity of 80 (exceeds 5 allowed). Consider refactoring.
Open

    public function toHTML() {
        $resolveFilesViaParser = $this->mParser instanceof Parser;
        if ( $resolveFilesViaParser ) {
            $parserOutput = $this->mParser->getOutput();
            $repoGroup = null;
Severity: Minor
Found in includes/gallery/TraditionalImageGallery.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method toHTML has 191 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toHTML() {
        $resolveFilesViaParser = $this->mParser instanceof Parser;
        if ( $resolveFilesViaParser ) {
            $parserOutput = $this->mParser->getOutput();
            $repoGroup = null;
Severity: Major
Found in includes/gallery/TraditionalImageGallery.php - About 7 hrs to fix

    File TraditionalImageGallery.php has 259 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

use MediaWiki\HookContainer\HookRunner;
use MediaWiki\Html\Html;
use MediaWiki\Linker\Linker;
    Severity: Minor
    Found in includes/gallery/TraditionalImageGallery.php - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

                  if ( !$img || !$thumb || ( !$enableLegacyMediaDOM && $thumb->isError() ) || $isBadFile ) {
                $rdfaType = 'mw:Error ' . $rdfaType;

                if ( $enableLegacyMediaDOM ) {
                    if ( $isBadFile ) {
      Severity: Major
      Found in includes/gallery/TraditionalImageGallery.php - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status