Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/htmlform/fields/HTMLSelectAndOtherField.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method getInputOOUI has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getInputOOUI( $value ) {
        $this->mParent->getOutput()->addModuleStyles( 'mediawiki.widgets.SelectWithInputWidget.styles' );

        # TextInput
        $textAttribs = [
Severity: Minor
Found in includes/htmlform/fields/HTMLSelectAndOtherField.php - About 2 hrs to fix

    Method getInputCodex has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getInputCodex( $value, $hasErrors ) {
        $select = parent::getInputCodex( $value[1], $hasErrors );

        // Set up attributes for the text input.
        $textInputAttribs = [
    Severity: Minor
    Found in includes/htmlform/fields/HTMLSelectAndOtherField.php - About 1 hr to fix

      Method getInputHTML has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getInputHTML( $value ) {
        $select = parent::getInputHTML( $value[1] );

        $textAttribs = [
            'size' => $this->getSize(),
      Severity: Minor
      Found in includes/htmlform/fields/HTMLSelectAndOtherField.php - About 1 hr to fix

        Function getDefault has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getDefault() {
        $default = parent::getDefault();

        // Default values of empty form
        $final = '';
        Severity: Minor
        Found in includes/htmlform/fields/HTMLSelectAndOtherField.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function loadDataFromRequest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function loadDataFromRequest( $request ) {
        if ( $request->getCheck( $this->mName ) ) {
            $list = $request->getText( $this->mName );
            $text = $request->getText( $this->mName . '-other' );
        Severity: Minor
        Found in includes/htmlform/fields/HTMLSelectAndOtherField.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status