includes/htmlform/fields/HTMLTitleTextField.php
Function validate has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
Open
public function validate( $value, $alldata ) {
if ( $this->mParams['interwiki'] && $this->mParams['relative'] ) {
// relative and interwiki cannot be used together, because we don't have a way to know about
// namespaces used by the other wiki (and it might actually be a non-wiki link, too).
throw new InvalidArgumentException( 'relative and interwiki may not be used together' );- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function validate( $value, $alldata ) {
if ( $this->mParams['interwiki'] && $this->mParams['relative'] ) {
// relative and interwiki cannot be used together, because we don't have a way to know about
// namespaces used by the other wiki (and it might actually be a non-wiki link, too).
throw new InvalidArgumentException( 'relative and interwiki may not be used together' );Avoid too many return statements within this method. Open
Open
return $this->msg( 'htmlform-title-badnamespace', $text, $this->mParams['namespace'] );Avoid too many return statements within this method. Open
Open
return $this->msg( 'htmlform-title-not-creatable', $text );Avoid too many return statements within this method. Open
Open
return $this->msg( 'htmlform-title-not-exists', $text );Avoid too many return statements within this method. Open
Open
return parent::validate( $value, $alldata );