wikimedia/mediawiki-core

View on GitHub
includes/htmlform/fields/HTMLUserTextField.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function validate has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate( $value, $alldata ) {
        // If the value is null, reset it to an empty string which is what is expected by the parent.
        if ( $value === null ) {
            $value = '';
        }
Severity: Minor
Found in includes/htmlform/fields/HTMLUserTextField.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate( $value, $alldata ) {
        // If the value is null, reset it to an empty string which is what is expected by the parent.
        if ( $value === null ) {
            $value = '';
        }
Severity: Minor
Found in includes/htmlform/fields/HTMLUserTextField.php - About 1 hr to fix

    Function isValidIPRange has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function isValidIPRange( $value ) {
            $cidrIPRanges = $this->mParams['iprangelimits'];
    
            if ( !IPUtils::isValidRange( $value ) ) {
                return false;
    Severity: Minor
    Found in includes/htmlform/fields/HTMLUserTextField.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return $this->msg( 'ip_range_exceeded', $cidrIPRanges['IPv6'] );
    Severity: Major
    Found in includes/htmlform/fields/HTMLUserTextField.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return parent::validate( $value, $alldata );
      Severity: Major
      Found in includes/htmlform/fields/HTMLUserTextField.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in includes/htmlform/fields/HTMLUserTextField.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status