Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/installer/DatabaseInstaller.php

Summary

Maintainability
D
1 day
Test Coverage

DatabaseInstaller has 38 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class DatabaseInstaller {
    /**
     * A connection for creating DBs, suitable for pre-installation.
     */
    public const CONN_CREATE_DATABASE = 'create-database';
Severity: Minor
Found in includes/installer/DatabaseInstaller.php - About 5 hrs to fix

    File DatabaseInstaller.php has 318 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * DBMS-specific installation helper.
 *
    Severity: Minor
    Found in includes/installer/DatabaseInstaller.php - About 3 hrs to fix

      Method populateInterwikiTable has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function populateInterwikiTable() {
        $status = $this->getConnection( self::CONN_CREATE_TABLES );
        if ( !$status->isOK() ) {
            return $status;
        }
      Severity: Minor
      Found in includes/installer/DatabaseInstaller.php - About 1 hr to fix

        Function getConnection has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getConnection( $type = self::CONN_DONT_KNOW ) {
        if ( $type === self::CONN_DONT_KNOW ) {
            if ( $this->cachedConnType ) {
                $type = $this->cachedConnType;
            } else {
        Severity: Minor
        Found in includes/installer/DatabaseInstaller.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method stepApplySourceFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function stepApplySourceFile(
        $sourceFileMethod,
        $stepName,
        $tableThatMustNotExist = false
    ) {
        Severity: Minor
        Found in includes/installer/DatabaseInstaller.php - About 1 hr to fix

          Function changeConnType has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function changeConnType( Database $conn, &$storedType, $newType ) {
        // Change type from database to schema, if requested
        if ( $storedType === self::CONN_CREATE_DATABASE ) {
            if ( $newType === self::CONN_CREATE_SCHEMA || $newType === self::CONN_CREATE_TABLES ) {
                $conn->selectDomain( new DatabaseDomain(
          Severity: Minor
          Found in includes/installer/DatabaseInstaller.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function populateInterwikiTable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function populateInterwikiTable() {
        $status = $this->getConnection( self::CONN_CREATE_TABLES );
        if ( !$status->isOK() ) {
            return $status;
        }
          Severity: Minor
          Found in includes/installer/DatabaseInstaller.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function stepApplySourceFile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function stepApplySourceFile(
        $sourceFileMethod,
        $stepName,
        $tableThatMustNotExist = false
    ) {
          Severity: Minor
          Found in includes/installer/DatabaseInstaller.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status