Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/installer/PostgresUpdater.php

Summary

Maintainability
F
5 days
Test Coverage

File PostgresUpdater.php has 843 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * PostgreSQL-specific updater.
 *
 * This program is free software; you can redistribute it and/or modify
Severity: Major
Found in includes/installer/PostgresUpdater.php - About 2 days to fix

    Method getCoreUpdateList has 404 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getCoreUpdateList() {
        return [
            // 1.35 but must come first
            [ 'addPgField', 'revision', 'rev_actor', 'INTEGER NOT NULL DEFAULT 0' ],
            [ 'addPgIndex', 'revision', 'rev_actor_timestamp', '(rev_actor,rev_timestamp,rev_id)' ],
    Severity: Major
    Found in includes/installer/PostgresUpdater.php - About 2 days to fix

      PostgresUpdater has 26 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class PostgresUpdater extends DatabaseUpdater {

    /**
     * @var DatabasePostgres
     */
      Severity: Minor
      Found in includes/installer/PostgresUpdater.php - About 3 hrs to fix

        Method describeIndex has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function describeIndex( $idx ) {
        // first fetch the key (which is a list of columns ords) and
        // the table the index applies to (an oid)
        $q = <<<END
SELECT indkey, indrelid FROM pg_namespace, pg_class, pg_index
        Severity: Minor
        Found in includes/installer/PostgresUpdater.php - About 1 hr to fix

          Function changeNullableField has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function changeNullableField( $table, $field, $null, $update = false ) {
        $fi = $this->db->fieldInfo( $table, $field );
        if ( $fi === null ) {
            return;
        }
          Severity: Minor
          Found in includes/installer/PostgresUpdater.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method changeNullableField has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function changeNullableField( $table, $field, $null, $update = false ) {
        $fi = $this->db->fieldInfo( $table, $field );
        if ( $fi === null ) {
            return;
        }
          Severity: Minor
          Found in includes/installer/PostgresUpdater.php - About 1 hr to fix

            Method renameIndex has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $table, $old, $new, $skipBothIndexExistWarning = false, $a = false, $b = false
            Severity: Minor
            Found in includes/installer/PostgresUpdater.php - About 45 mins to fix

              Function changeField has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function changeField( $table, $field, $newtype, $default ) {
        $fi = $this->db->fieldInfo( $table, $field );
        if ( $fi === null ) {
            $this->output( "...ERROR: expected column $table.$field to exist\n" );
            exit( 1 );
              Severity: Minor
              Found in includes/installer/PostgresUpdater.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function changeFieldPurgeTable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function changeFieldPurgeTable( $table, $field, $newtype, $default ) {
        # # For a cache table, empty it if the field needs to be changed, because the old contents
        # # may be corrupted.  If the column is already the desired type, refrain from purging.
        $fi = $this->db->fieldInfo( $table, $field );
        if ( $fi === null ) {
              Severity: Minor
              Found in includes/installer/PostgresUpdater.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function describeIndex has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function describeIndex( $idx ) {
        // first fetch the key (which is a list of columns ords) and
        // the table the index applies to (an oid)
        $q = <<<END
SELECT indkey, indrelid FROM pg_namespace, pg_class, pg_index
              Severity: Minor
              Found in includes/installer/PostgresUpdater.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return $colnames;
              Severity: Major
              Found in includes/installer/PostgresUpdater.php - About 30 mins to fix

                Function renameIndex has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function renameIndex(
        $table, $old, $new, $skipBothIndexExistWarning = false, $a = false, $b = false
    ) {
        // First requirement: the table must exist
        if ( !$this->db->tableExists( $table, __METHOD__ ) ) {
                Severity: Minor
                Found in includes/installer/PostgresUpdater.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    protected function setDefault( $table, $field, $default ) {
        $info = $this->db->fieldInfo( $table, $field );
        if ( $info && $info->defaultValue() !== $default ) {
            $this->output( "Changing '$table.$field' default value\n" );
            $table = $this->db->addIdentifierQuotes( $table );
                Severity: Major
                Found in includes/installer/PostgresUpdater.php and 1 other location - About 1 hr to fix
                includes/installer/MysqlUpdater.php on lines 292..302

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 112.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if ( strlen( $default ) ) {
                $res = [];
                if ( preg_match( '/DEFAULT (.+)/', $default, $res ) ) {
                    $sqldef = "ALTER TABLE $table ALTER $field SET DEFAULT $res[1]";
                    $this->db->query( $sqldef, __METHOD__ );
                Severity: Minor
                Found in includes/installer/PostgresUpdater.php and 1 other location - About 1 hr to fix
                includes/installer/PostgresUpdater.php on lines 756..764

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 100.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if ( strlen( $default ) ) {
                $res = [];
                if ( preg_match( '/DEFAULT (.+)/', $default, $res ) ) {
                    $sqldef = "ALTER TABLE $table ALTER $field SET DEFAULT $res[1]";
                    $this->db->query( $sqldef, __METHOD__ );
                Severity: Minor
                Found in includes/installer/PostgresUpdater.php and 1 other location - About 1 hr to fix
                includes/installer/PostgresUpdater.php on lines 726..734

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 100.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( $this->db->indexExists( $table, $new, __METHOD__ ) ) {
            $this->output( "...index $new already set on $table table.\n" );
            if ( !$skipBothIndexExistWarning
                && $this->db->indexExists( $table, $old, __METHOD__ )
            ) {
                Severity: Minor
                Found in includes/installer/PostgresUpdater.php and 1 other location - About 40 mins to fix
                includes/installer/DatabaseUpdater.php on lines 949..960

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 94.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status