Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/jobqueue/JobQueue.php

Summary

Maintainability
C
1 day
Test Coverage

JobQueue has 52 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class JobQueue {
    /** @var string DB domain ID */
    protected $domain;
    /** @var string Job type */
    protected $type;
Severity: Major
Found in includes/jobqueue/JobQueue.php - About 7 hrs to fix

    File JobQueue.php has 259 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/jobqueue/JobQueue.php - About 2 hrs to fix

      Function batchPush has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          final public function batchPush( array $jobs, $flags = 0 ) {
        $this->assertNotReadOnly();

        if ( $jobs === [] ) {
            return; // nothing to do
      Severity: Minor
      Found in includes/jobqueue/JobQueue.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function __construct( array $params ) {
        $this->domain = $params['domain'] ?? $params['wiki']; // b/c
        $this->type = $params['type'];
        $this->claimTTL = $params['claimTTL'] ?? 0;
        $this->maxTries = $params['maxTries'] ?? 3;
      Severity: Minor
      Found in includes/jobqueue/JobQueue.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status