Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/jobqueue/JobRunner.php

Summary

Maintainability
D
3 days
Test Coverage

Function run has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    public function run( array $options ) {
        $type = $options['type'] ?? false;
        $maxJobs = $options['maxJobs'] ?? false;
        $maxTime = $options['maxTime'] ?? false;
        $throttle = $options['throttle'] ?? true;
Severity: Minor
Found in includes/jobqueue/JobRunner.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File JobRunner.php has 358 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/jobqueue/JobRunner.php - About 4 hrs to fix

    Method run has 97 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run( array $options ) {
        $type = $options['type'] ?? false;
        $maxJobs = $options['maxJobs'] ?? false;
        $maxTime = $options['maxTime'] ?? false;
        $throttle = $options['throttle'] ?? true;
    Severity: Major
    Found in includes/jobqueue/JobRunner.php - About 3 hrs to fix

      Method doExecuteJob has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function doExecuteJob( RunnableJob $job ) {
        $jType = $job->getType();
        $msg = $job->toString() . " STARTING";
        $this->logger->debug( $msg, [ 'job_type' => $job->getType() ] );
        $this->debugCallback( $msg );
      Severity: Major
      Found in includes/jobqueue/JobRunner.php - About 3 hrs to fix

        Method syncBackoffDeltas has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function syncBackoffDeltas( array $backoffs, array &$deltas, $mode = 'wait' ) {
        if ( !$deltas ) {
            return $this->loadBackoffs( $backoffs, $mode );
        }
        Severity: Minor
        Found in includes/jobqueue/JobRunner.php - About 1 hr to fix

          Function doExecuteJob has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              private function doExecuteJob( RunnableJob $job ) {
        $jType = $job->getType();
        $msg = $job->toString() . " STARTING";
        $this->logger->debug( $msg, [ 'job_type' => $job->getType() ] );
        $this->debugCallback( $msg );
          Severity: Minor
          Found in includes/jobqueue/JobRunner.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function loadBackoffs has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              private function loadBackoffs( array $backoffs, $mode = 'wait' ) {
        $file = wfTempDir() . '/mw-runJobs-backoffs.json';
        if ( is_file( $file ) ) {
            $noblock = ( $mode === 'nowait' ) ? LOCK_NB : 0;
            $handle = fopen( $file, 'rb' );
          Severity: Minor
          Found in includes/jobqueue/JobRunner.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  ServiceOptions $serviceOptions,
        ILBFactory $lbFactory,
        JobQueueGroup $jobQueueGroup,
        ReadOnlyMode $readOnlyMode,
        LinkCache $linkCache,
          Severity: Major
          Found in includes/jobqueue/JobRunner.php - About 50 mins to fix

            Function syncBackoffDeltas has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function syncBackoffDeltas( array $backoffs, array &$deltas, $mode = 'wait' ) {
        if ( !$deltas ) {
            return $this->loadBackoffs( $backoffs, $mode );
        }
            Severity: Minor
            Found in includes/jobqueue/JobRunner.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function checkMemoryOK has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function checkMemoryOK() {
        static $maxBytes = null;
        if ( $maxBytes === null ) {
            $m = [];
            if ( preg_match( '!^(\d+)(k|m|g|)$!i', ini_get( 'memory_limit' ), $m ) ) {
            Severity: Minor
            Found in includes/jobqueue/JobRunner.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function __construct(
        ServiceOptions $serviceOptions,
        ILBFactory $lbFactory,
        JobQueueGroup $jobQueueGroup,
        ReadOnlyMode $readOnlyMode,
            Severity: Major
            Found in includes/jobqueue/JobRunner.php and 2 other locations - About 2 hrs to fix
            includes/editpage/Constraint/EditConstraintFactory.php on lines 94..123
            includes/logging/LogFormatterFactory.php on lines 25..42

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 128.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status