includes/jobqueue/jobs/DoubleRedirectJob.php
Method run has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function run() {
if ( !$this->redirTitle ) {
$this->setLastError( 'Invalid title' );
return false;Method fixRedirects has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function fixRedirects( $reason, $redirTitle ) {
# Need to use the primary DB to get the redirect table updated in the same transaction
$services = MediaWikiServices::getInstance();
$dbw = $services->getConnectionProvider()->getPrimaryDatabase();
$res = $dbw->newSelectQueryBuilder()Method getFinalDestination has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function getFinalDestination( $title ) {
$dbw = MediaWikiServices::getInstance()->getConnectionProvider()->getPrimaryDatabase();
// Circular redirect check
$seenTitles = [];Function getFinalDestination has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
public static function getFinalDestination( $title ) {
$dbw = MediaWikiServices::getInstance()->getConnectionProvider()->getPrimaryDatabase();
// Circular redirect check
$seenTitles = [];- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
public function run() {
if ( !$this->redirTitle ) {
$this->setLastError( 'Invalid title' );
return false;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function fixRedirects has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
public static function fixRedirects( $reason, $redirTitle ) {
# Need to use the primary DB to get the redirect table updated in the same transaction
$services = MediaWikiServices::getInstance();
$dbw = $services->getConnectionProvider()->getPrimaryDatabase();
$res = $dbw->newSelectQueryBuilder()- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
PageReference $page,
array $params,
RevisionLookup $revisionLookup,
MagicWordFactory $magicWordFactory,
WikiPageFactory $wikiPageFactoryAvoid too many return statements within this method. Open
Open
return true;Avoid too many return statements within this method. Open
Open
return true;Avoid too many return statements within this method. Open
Open
return true;Avoid too many return statements within this method. Open
Open
return false;Avoid too many return statements within this method. Open
Open
return false;