Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/jobqueue/jobs/RefreshLinksJob.php

Summary

Maintainability
D
1 day
Test Coverage

File RefreshLinksJob.php has 332 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/jobqueue/jobs/RefreshLinksJob.php - About 4 hrs to fix

    Method getParserOutput has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getParserOutput(
        RevisionRenderer $renderer,
        ParserCache $parserCache,
        WikiPage $page,
        StatsFactory $stats
    Severity: Major
    Found in includes/jobqueue/jobs/RefreshLinksJob.php - About 2 hrs to fix

      Function run has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run() {
        $ok = true;

        if ( !empty( $this->params['recursive'] ) ) {
            // Job to update all (or a range of) backlink pages for a page
      Severity: Minor
      Found in includes/jobqueue/jobs/RefreshLinksJob.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method runForTitle has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function runForTitle( PageIdentity $pageIdentity ) {
        $services = MediaWikiServices::getInstance();
        $stats = $services->getStatsFactory();
        $renderer = $services->getRevisionRenderer();
        $parserCache = $services->getParserCache();
      Severity: Minor
      Found in includes/jobqueue/jobs/RefreshLinksJob.php - About 1 hr to fix

        Method run has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run() {
        $ok = true;

        if ( !empty( $this->params['recursive'] ) ) {
            // Job to update all (or a range of) backlink pages for a page
        Severity: Minor
        Found in includes/jobqueue/jobs/RefreshLinksJob.php - About 1 hr to fix

          Function getParserOutput has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getParserOutput(
        RevisionRenderer $renderer,
        ParserCache $parserCache,
        WikiPage $page,
        StatsFactory $stats
          Severity: Minor
          Found in includes/jobqueue/jobs/RefreshLinksJob.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in includes/jobqueue/jobs/RefreshLinksJob.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status