Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/libs/ArrayUtils.php

Summary

Maintainability
C
1 day
Test Coverage

Function arrayDiffAssocRecursive has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public static function arrayDiffAssocRecursive( $array1, ...$arrays ) {
        $ret = [];

        foreach ( $array1 as $key => $value ) {
            if ( is_array( $value ) ) {
Severity: Minor
Found in includes/libs/ArrayUtils.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function cartesianProduct has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public static function cartesianProduct( ...$inputArrays ) {
        $numInputs = count( $inputArrays );
        if ( $numInputs === 0 ) {
            return [];
        }
Severity: Minor
Found in includes/libs/ArrayUtils.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cartesianProduct has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function cartesianProduct( ...$inputArrays ) {
        $numInputs = count( $inputArrays );
        if ( $numInputs === 0 ) {
            return [];
        }
Severity: Minor
Found in includes/libs/ArrayUtils.php - About 1 hr to fix

    Method findLowerBound has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function findLowerBound( $valueCallback, $valueCount,
        $comparisonCallback, $target
    ) {
        if ( $valueCount === 0 ) {
            return false;
    Severity: Minor
    Found in includes/libs/ArrayUtils.php - About 1 hr to fix

      Function pickRandom has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function pickRandom( $weights ) {
        if ( !is_array( $weights ) || count( $weights ) == 0 ) {
            return false;
        }
      Severity: Minor
      Found in includes/libs/ArrayUtils.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function findLowerBound has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function findLowerBound( $valueCallback, $valueCount,
        $comparisonCallback, $target
    ) {
        if ( $valueCount === 0 ) {
            return false;
      Severity: Minor
      Found in includes/libs/ArrayUtils.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status