Function doUnlockByType
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
protected function doUnlockByType( array $pathsByType ) {
$status = StatusValue::newGood();
$pathsByTypeByBucket = []; // (bucket => type => paths)
foreach ( $pathsByType as $type => $paths ) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function doLockByType
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
final protected function doLockByType( array $pathsByType ) {
$status = StatusValue::newGood();
$pathsByTypeByBucket = []; // (bucket => type => paths)
// Get locks that need to be acquired (buckets => locks)...
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function collectPledgeQuorum
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
final protected function collectPledgeQuorum( $bucket, callable $callback ) {
$status = StatusValue::newGood();
$yesVotes = 0; // locks made on trustable servers
$votesLeft = count( $this->srvsByBucket[$bucket] ); // remaining peers
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method doLockByType
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
final protected function doLockByType( array $pathsByType ) {
$status = StatusValue::newGood();
$pathsByTypeByBucket = []; // (bucket => type => paths)
// Get locks that need to be acquired (buckets => locks)...
Method doUnlockByType
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function doUnlockByType( array $pathsByType ) {
$status = StatusValue::newGood();
$pathsByTypeByBucket = []; // (bucket => type => paths)
foreach ( $pathsByType as $type => $paths ) {
Method collectPledgeQuorum
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
final protected function collectPledgeQuorum( $bucket, callable $callback ) {
$status = StatusValue::newGood();
$yesVotes = 0; // locks made on trustable servers
$votesLeft = count( $this->srvsByBucket[$bucket] ); // remaining peers
Function releasePledges
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
final protected function releasePledges( $bucket, callable $callback ) {
$status = StatusValue::newGood();
$yesVotes = 0; // locks freed on trustable servers
$votesLeft = count( $this->srvsByBucket[$bucket] ); // remaining peers
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"