Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/libs/mime/MSCompoundFileReader.php

Summary

Maintainability
C
7 hrs
Test Coverage

File MSCompoundFileReader.php has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2019 Wikimedia Foundation
 *
 * Licensed under the Apache License, Version 2.0 (the "License"); you may
Severity: Minor
Found in includes/libs/mime/MSCompoundFileReader.php - About 2 hrs to fix

    Method readDirectory has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function readDirectory() {
        $dirSectorId = $this->header['first_dir_sector'];
        $binaryDir = '';
        $seenSectorIds = [];
        while ( $dirSectorId !== 0xFFFFFFFE ) {
    Severity: Minor
    Found in includes/libs/mime/MSCompoundFileReader.php - About 2 hrs to fix

      Function readDirectory has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          private function readDirectory() {
        $dirSectorId = $this->header['first_dir_sector'];
        $binaryDir = '';
        $seenSectorIds = [];
        while ( $dirSectorId !== 0xFFFFFFFE ) {
      Severity: Minor
      Found in includes/libs/mime/MSCompoundFileReader.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method init has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function init() {
        $this->header = $this->unpackOffset( 0, [
            'header_signature' => 8,
            'header_clsid' => 16,
            'minor_version' => 2,
      Severity: Minor
      Found in includes/libs/mime/MSCompoundFileReader.php - About 1 hr to fix

        Function readDifat has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function readDifat() {
        $binaryDifat = $this->header['difat'];
        $nextDifatSector = $this->header['first_difat_sector'];
        for ( $i = 0; $i < $this->header['num_difat_sectors']; $i++ ) {
            $block = $this->readSector( $nextDifatSector );
        Severity: Minor
        Found in includes/libs/mime/MSCompoundFileReader.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status