Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/libs/objectcache/APCUBagOStuff.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function doIncrWithInit has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected function doIncrWithInit( $key, $exptime, $step, $init, $flags ) {
        // Use apcu 5.1.12 $ttl argument if apcu_inc() will initialize to $init:
        // https://www.php.net/manual/en/function.apcu-inc.php
        if ( $step === $init ) {
            /** @noinspection PhpMethodParametersCountMismatchInspection */
Severity: Minor
Found in includes/libs/objectcache/APCUBagOStuff.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doIncrWithInit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function doIncrWithInit( $key, $exptime, $step, $init, $flags ) {
        // Use apcu 5.1.12 $ttl argument if apcu_inc() will initialize to $init:
        // https://www.php.net/manual/en/function.apcu-inc.php
        if ( $step === $init ) {
            /** @noinspection PhpMethodParametersCountMismatchInspection */
Severity: Minor
Found in includes/libs/objectcache/APCUBagOStuff.php - About 1 hr to fix

    Method doIncrWithInit has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function doIncrWithInit( $key, $exptime, $step, $init, $flags ) {
    Severity: Minor
    Found in includes/libs/objectcache/APCUBagOStuff.php - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status