Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/libs/objectcache/MemcachedPeclBagOStuff.php

Summary

Maintainability
C
1 day
Test Coverage

File MemcachedPeclBagOStuff.php has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/libs/objectcache/MemcachedPeclBagOStuff.php - About 3 hrs to fix

    Method initializeClient has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function initializeClient( Memcached $client, array $params ) {
        if ( $client->getServerList() ) {
            $this->logger->debug( __METHOD__ . ": pre-initialized client instance." );

            return; // preserve persistent handle
    Severity: Major
    Found in includes/libs/objectcache/MemcachedPeclBagOStuff.php - About 2 hrs to fix

      Function initializeClient has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          private function initializeClient( Memcached $client, array $params ) {
        if ( $client->getServerList() ) {
            $this->logger->debug( __METHOD__ . ": pre-initialized client instance." );

            return; // preserve persistent handle
      Severity: Minor
      Found in includes/libs/objectcache/MemcachedPeclBagOStuff.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method checkResult has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function checkResult( $key, $result ) {
        static $statusByCode = [
            Memcached::RES_HOST_LOOKUP_FAILURE => self::ERR_UNREACHABLE,
            Memcached::RES_SERVER_MARKED_DEAD => self::ERR_UNREACHABLE,
            Memcached::RES_SERVER_TEMPORARILY_DISABLED => self::ERR_UNREACHABLE,
      Severity: Minor
      Found in includes/libs/objectcache/MemcachedPeclBagOStuff.php - About 1 hr to fix

        Method doCas has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected function doCas( $casToken, $key, $value, $exptime = 0, $flags = 0 ) {
        Severity: Minor
        Found in includes/libs/objectcache/MemcachedPeclBagOStuff.php - About 35 mins to fix

          Function checkResult has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function checkResult( $key, $result ) {
        static $statusByCode = [
            Memcached::RES_HOST_LOOKUP_FAILURE => self::ERR_UNREACHABLE,
            Memcached::RES_SERVER_MARKED_DEAD => self::ERR_UNREACHABLE,
            Memcached::RES_SERVER_TEMPORARILY_DISABLED => self::ERR_UNREACHABLE,
          Severity: Minor
          Found in includes/libs/objectcache/MemcachedPeclBagOStuff.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status