wikimedia/mediawiki-core

View on GitHub
includes/libs/objectcache/RESTBagOStuff.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function handleError has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    protected function handleError( $msg, $rcode, $rerr, $rhdrs, $rbody, $context = [] ) {
        $message = "$msg : ({code}) {error}";
        $context = [
            'code' => $rcode,
            'error' => $rerr
Severity: Minor
Found in includes/libs/objectcache/RESTBagOStuff.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct( $params ) {
        $params['segmentationSize'] ??= INF;
        if ( empty( $params['url'] ) ) {
            throw new InvalidArgumentException( 'URL parameter is required' );
        }
Severity: Minor
Found in includes/libs/objectcache/RESTBagOStuff.php - About 1 hr to fix

    Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct( $params ) {
            $params['segmentationSize'] ??= INF;
            if ( empty( $params['url'] ) ) {
                throw new InvalidArgumentException( 'URL parameter is required' );
            }
    Severity: Minor
    Found in includes/libs/objectcache/RESTBagOStuff.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function doGet has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function doGet( $key, $flags = 0, &$casToken = null ) {
            $getToken = ( $casToken === self::PASS_BY_REF );
            $casToken = null;
    
            $req = [
    Severity: Minor
    Found in includes/libs/objectcache/RESTBagOStuff.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handleError has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function handleError( $msg, $rcode, $rerr, $rhdrs, $rbody, $context = [] ) {
    Severity: Minor
    Found in includes/libs/objectcache/RESTBagOStuff.php - About 45 mins to fix

      Method doIncrWithInit has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function doIncrWithInit( $key, $exptime, $step, $init, $flags ) {
      Severity: Minor
      Found in includes/libs/objectcache/RESTBagOStuff.php - About 35 mins to fix

        Function decodeBody has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function decodeBody( $body ) {
                $pieces = explode( '.', $body, 3 );
                if ( count( $pieces ) !== 3 || $pieces[0] !== $this->serializationType ) {
                    return false;
                }
        Severity: Minor
        Found in includes/libs/objectcache/RESTBagOStuff.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function encodeBody has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function encodeBody( $body ) {
                switch ( $this->serializationType ) {
                    case 'JSON':
                        $value = json_encode( $body );
                        if ( $value === false ) {
        Severity: Minor
        Found in includes/libs/objectcache/RESTBagOStuff.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status