Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/libs/rdbms/database/position/MySQLPrimaryPos.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function init has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    protected function init( $position, $asOfTime ) {
        $m = [];
        if ( preg_match( '!^(.+)\.(\d+)/(\d+)$!', $position, $m ) ) {
            $this->binLog = $m[1]; // ideally something like host name
            $this->logPos = [ self::CORD_INDEX => (int)$m[2], self::CORD_EVENT => $m[3] ];
Severity: Minor
Found in includes/libs/rdbms/database/position/MySQLPrimaryPos.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getActiveGtidCoordinates has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getActiveGtidCoordinates() {
        $gtidInfos = [];

        foreach ( $this->gtids as $gtid ) {
            [ $domain, $pos, $server ] = self::parseGTID( $gtid );
Severity: Minor
Found in includes/libs/rdbms/database/position/MySQLPrimaryPos.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method init has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function init( $position, $asOfTime ) {
        $m = [];
        if ( preg_match( '!^(.+)\.(\d+)/(\d+)$!', $position, $m ) ) {
            $this->binLog = $m[1]; // ideally something like host name
            $this->logPos = [ self::CORD_INDEX => (int)$m[2], self::CORD_EVENT => $m[3] ];
Severity: Minor
Found in includes/libs/rdbms/database/position/MySQLPrimaryPos.php - About 1 hr to fix

    Function hasReached has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function hasReached( DBPrimaryPos $pos ) {
        if ( !( $pos instanceof self ) ) {
            throw new InvalidArgumentException( "Position not an instance of " . __CLASS__ );
        }
    Severity: Minor
    Found in includes/libs/rdbms/database/position/MySQLPrimaryPos.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status