wikimedia/mediawiki-core

View on GitHub
includes/libs/rdbms/database/replication/MysqlReplicationReporter.php

Summary

Maintainability
D
2 days
Test Coverage

File MysqlReplicationReporter.php has 364 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/libs/rdbms/database/replication/MysqlReplicationReporter.php - About 4 hrs to fix

    Method primaryPosWait has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function primaryPosWait( IDatabase $conn, DBPrimaryPos $pos, $timeout ) {
            if ( !( $pos instanceof MySQLPrimaryPos ) ) {
                throw new InvalidArgumentException( "Position not an instance of MySQLPrimaryPos" );
            }
    
    
    Severity: Major
    Found in includes/libs/rdbms/database/replication/MysqlReplicationReporter.php - About 4 hrs to fix

      Function primaryPosWait has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function primaryPosWait( IDatabase $conn, DBPrimaryPos $pos, $timeout ) {
              if ( !( $pos instanceof MySQLPrimaryPos ) ) {
                  throw new InvalidArgumentException( "Position not an instance of MySQLPrimaryPos" );
              }
      
      
      Severity: Minor
      Found in includes/libs/rdbms/database/replication/MysqlReplicationReporter.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getPrimaryPos has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getPrimaryPos( IDatabase $conn ) {
              $now = microtime( true ); // as-of-time *before* fetching GTID variables
      
              $pos = false;
              if ( $this->useGTIDs() ) {
      Severity: Minor
      Found in includes/libs/rdbms/database/replication/MysqlReplicationReporter.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getLagFromPtHeartbeat has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getLagFromPtHeartbeat( IDatabase $conn ) {
              $currentTrxInfo = $this->getRecordedTransactionLagStatus( $conn );
              if ( $currentTrxInfo ) {
                  // There is an active transaction and the initial lag was already queried
                  $staleness = microtime( true ) - $currentTrxInfo['since'];

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $topologyRole,
                $logger,
                $srvCache,
                $lagDetectionMethod,
                $lagDetectionOptions,
        Severity: Minor
        Found in includes/libs/rdbms/database/replication/MysqlReplicationReporter.php - About 45 mins to fix

          Function getReplicaPos has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getReplicaPos( IDatabase $conn ) {
                  $now = microtime( true ); // as-of-time *before* fetching GTID variables
          
                  if ( $this->useGTIDs() ) {
                      // Try to use GTIDs, fallbacking to binlog positions if not possible
          Severity: Minor
          Found in includes/libs/rdbms/database/replication/MysqlReplicationReporter.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return $status;
          Severity: Major
          Found in includes/libs/rdbms/database/replication/MysqlReplicationReporter.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status