Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/libs/rdbms/expression/Expression.php

Summary

Maintainability
C
1 day
Test Coverage

Function toSql has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function toSql( DbQuoter $dbQuoter ): string {
        if ( is_array( $this->value ) ) {
            if ( count( $this->value ) === 1 ) {
                $value = $this->value[0];
                if ( $this->op === '=' ) {
Severity: Minor
Found in includes/libs/rdbms/expression/Expression.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __construct has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct( string $field, string $op, $value ) {
        if ( !in_array( $op, IExpression::ACCEPTABLE_OPERATORS ) ) {
            throw new InvalidArgumentException( "Operator $op is not supported" );
        }
        if (
Severity: Minor
Found in includes/libs/rdbms/expression/Expression.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method toSql has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toSql( DbQuoter $dbQuoter ): string {
        if ( is_array( $this->value ) ) {
            if ( count( $this->value ) === 1 ) {
                $value = $this->value[0];
                if ( $this->op === '=' ) {
Severity: Minor
Found in includes/libs/rdbms/expression/Expression.php - About 1 hr to fix

    Method __construct has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct( string $field, string $op, $value ) {
        if ( !in_array( $op, IExpression::ACCEPTABLE_OPERATORS ) ) {
            throw new InvalidArgumentException( "Operator $op is not supported" );
        }
        if (
    Severity: Minor
    Found in includes/libs/rdbms/expression/Expression.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                      return $this->field . " IS NULL";
      Severity: Major
      Found in includes/libs/rdbms/expression/Expression.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->field . " IS NOT NULL";
        Severity: Major
        Found in includes/libs/rdbms/expression/Expression.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $this->field . ' ' . $this->op . ' ' . $this->value->toSql( $dbQuoter );
          Severity: Major
          Found in includes/libs/rdbms/expression/Expression.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $this->field . ' ' . $this->op . ' ' . $dbQuoter->addQuotes( $this->value );
            Severity: Major
            Found in includes/libs/rdbms/expression/Expression.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status