Method computeServerState has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function computeServerState( int $i, ?array $previousState ) {
$startTime = $this->getCurrentTime();
// Double check for circular recursion in computeServerStates()/getWeightScale().
// Mainly, connection attempts should use LoadBalancer::getServerConnection()
// rather than something that will pick a server based on the server states.Method scaleLoads has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function scaleLoads( array &$weightByServer ) {
if ( count( $weightByServer ) <= 1 ) {
// Single-server group; relative adjustments are pointless
return;
}Function computeServerState has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
protected function computeServerState( int $i, ?array $previousState ) {
$startTime = $this->getCurrentTime();
// Double check for circular recursion in computeServerStates()/getWeightScale().
// Mainly, connection attempts should use LoadBalancer::getServerConnection()
// rather than something that will pick a server based on the server states.- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function scaleLoads has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
public function scaleLoads( array &$weightByServer ) {
if ( count( $weightByServer ) <= 1 ) {
// Single-server group; relative adjustments are pointless
return;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getServerStates has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function getServerStates( array $serverIndexes ): array {
$stateByServerIndex = array_fill_keys( $serverIndexes, null );
// Perform any cache regenerations in randomized order so that the
// DB servers will each have similarly up-to-date state cache entries.
$shuffledServerIndexes = $serverIndexes;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"