Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/libs/rdbms/platform/PostgresPlatform.php

Summary

Maintainability
C
1 day
Test Coverage

Function selectSQLText has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    public function selectSQLText(
        $table, $vars, $conds = '', $fname = __METHOD__, $options = [], $join_conds = []
    ) {
        if ( is_string( $options ) ) {
            $options = [ $options ];
Severity: Minor
Found in includes/libs/rdbms/platform/PostgresPlatform.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function makeInsertLists has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function makeInsertLists( array $rows, $aliasPrefix = '', array $typeByColumn = [] ) {
        $firstRow = $rows[0];
        if ( !is_array( $firstRow ) || !$firstRow ) {
            throw new DBLanguageError( 'Got an empty row list or empty row' );
        }
Severity: Minor
Found in includes/libs/rdbms/platform/PostgresPlatform.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method selectSQLText has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function selectSQLText(
        $table, $vars, $conds = '', $fname = __METHOD__, $options = [], $join_conds = []
    ) {
        if ( is_string( $options ) ) {
            $options = [ $options ];
Severity: Minor
Found in includes/libs/rdbms/platform/PostgresPlatform.php - About 1 hr to fix

    Method makeInsertLists has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function makeInsertLists( array $rows, $aliasPrefix = '', array $typeByColumn = [] ) {
        $firstRow = $rows[0];
        if ( !is_array( $firstRow ) || !$firstRow ) {
            throw new DBLanguageError( 'Got an empty row list or empty row' );
        }
    Severity: Minor
    Found in includes/libs/rdbms/platform/PostgresPlatform.php - About 1 hr to fix

      Method selectSQLText has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $table, $vars, $conds = '', $fname = __METHOD__, $options = [], $join_conds = []
      Severity: Minor
      Found in includes/libs/rdbms/platform/PostgresPlatform.php - About 45 mins to fix

        Method buildGroupConcatField has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $delim, $table, $field, $conds = '', $join_conds = []
        Severity: Minor
        Found in includes/libs/rdbms/platform/PostgresPlatform.php - About 35 mins to fix

          Function makeSelectOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function makeSelectOptions( array $options ) {
        $preLimitTail = $postLimitTail = '';
        $startOpts = '';

        $noKeyOptions = [];
          Severity: Minor
          Found in includes/libs/rdbms/platform/PostgresPlatform.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function buildGroupConcatField(
        $delim, $table, $field, $conds = '', $join_conds = []
    ) {
        $fld = "array_to_string(array_agg($field)," . $this->quoter->addQuotes( $delim ) . ')';
          Severity: Minor
          Found in includes/libs/rdbms/platform/PostgresPlatform.php and 1 other location - About 35 mins to fix
          includes/libs/rdbms/platform/SqlitePlatform.php on lines 104..110

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 92.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status