Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/linker/LinkRenderer.php

Summary

Maintainability
C
1 day
Test Coverage

File LinkRenderer.php has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/linker/LinkRenderer.php - About 3 hrs to fix

    LinkRenderer has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class LinkRenderer {

    public const CONSTRUCTOR_OPTIONS = [
        'renderForComment',
    ];
    Severity: Minor
    Found in includes/linker/LinkRenderer.php - About 2 hrs to fix

      Method makeExternalLink has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function makeExternalLink(
        string $url, $text, LinkTarget $title, $linktype = '', $attribs = []
    ) {
        $class = 'external';
        if ( $linktype ) {
      Severity: Minor
      Found in includes/linker/LinkRenderer.php - About 1 hr to fix

        Method makeBrokenLink has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function makeBrokenLink(
        $target, $text = null, array $extraAttribs = [], array $query = []
    ) {
        Assert::parameterType( [ LinkTarget::class, PageReference::class ], $target, '$target' );
        // Run legacy hook
        Severity: Minor
        Found in includes/linker/LinkRenderer.php - About 1 hr to fix

          Function makeExternalLink has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function makeExternalLink(
        string $url, $text, LinkTarget $title, $linktype = '', $attribs = []
    ) {
        $class = 'external';
        if ( $linktype ) {
          Severity: Minor
          Found in includes/linker/LinkRenderer.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  TitleFormatter $titleFormatter,
        LinkCache $linkCache,
        SpecialPageFactory $specialPageFactory,
        HookContainer $hookContainer,
        ServiceOptions $options
          Severity: Minor
          Found in includes/linker/LinkRenderer.php - About 35 mins to fix

            Method makeExternalLink has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    string $url, $text, LinkTarget $title, $linktype = '', $attribs = []
            Severity: Minor
            Found in includes/linker/LinkRenderer.php - About 35 mins to fix

              Method makePreloadedLink has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $target, $text = null, $classes = '', array $extraAttribs = [], array $query = []
              Severity: Minor
              Found in includes/linker/LinkRenderer.php - About 35 mins to fix

                Function makeBrokenLink has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function makeBrokenLink(
        $target, $text = null, array $extraAttribs = [], array $query = []
    ) {
        Assert::parameterType( [ LinkTarget::class, PageReference::class ], $target, '$target' );
        // Run legacy hook
                Severity: Minor
                Found in includes/linker/LinkRenderer.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status