Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/linker/LinkTargetStore.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method getLinkTargetIdFromCache has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getLinkTargetIdFromCache( LinkTarget $linkTarget ) {
        $linkTargetString = (string)$linkTarget;
        if ( isset( $this->byTitleCache[$linkTargetString] ) ) {
            return $this->byTitleCache[$linkTargetString];
        }
Severity: Minor
Found in includes/linker/LinkTargetStore.php - About 1 hr to fix

    Method acquireLinkTargetId has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function acquireLinkTargetId( LinkTarget $linkTarget, IDatabase $dbw ): int {
        // allow cache to be used, because if it is in the cache, it already has a linktarget id
        $existingLinktargetId = $this->getLinkTargetIdFromCache( $linkTarget );
        if ( $existingLinktargetId ) {
            return $existingLinktargetId;
    Severity: Minor
    Found in includes/linker/LinkTargetStore.php - About 1 hr to fix

      Function acquireLinkTargetId has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function acquireLinkTargetId( LinkTarget $linkTarget, IDatabase $dbw ): int {
        // allow cache to be used, because if it is in the cache, it already has a linktarget id
        $existingLinktargetId = $this->getLinkTargetIdFromCache( $linkTarget );
        if ( $existingLinktargetId ) {
            return $existingLinktargetId;
      Severity: Minor
      Found in includes/linker/LinkTargetStore.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status