Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/logging/LogPage.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method saveContent has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function saveContent() {
        $logRestrictions = MediaWikiServices::getInstance()->getMainConfig()->get( MainConfigNames::LogRestrictions );

        $dbw = MediaWikiServices::getInstance()->getConnectionProvider()->getPrimaryDatabase();
Severity: Minor
Found in includes/logging/LogPage.php - About 1 hr to fix

    Method actionText has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function actionText( $type, $action, $title = null, $skin = null,
        $params = [], $filterWikilinks = false
    ) {
        global $wgLang;
        $config = MediaWikiServices::getInstance()->getMainConfig();
    Severity: Minor
    Found in includes/logging/LogPage.php - About 1 hr to fix

      Function actionText has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function actionText( $type, $action, $title = null, $skin = null,
        $params = [], $filterWikilinks = false
    ) {
        global $wgLang;
        $config = MediaWikiServices::getInstance()->getMainConfig();
      Severity: Minor
      Found in includes/logging/LogPage.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method actionText has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static function actionText( $type, $action, $title = null, $skin = null,
        $params = [], $filterWikilinks = false
      Severity: Minor
      Found in includes/logging/LogPage.php - About 45 mins to fix

        Method addEntry has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function addEntry( $action, $target, $comment, $params, $performer ) {
        Severity: Minor
        Found in includes/logging/LogPage.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status