Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/logging/LogPager.php

Summary

Maintainability
D
2 days
Test Coverage

File LogPager.php has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Contain classes to list log entries
 *
 * Copyright © 2004 Brooke Vibber <bvibber@wikimedia.org>
Severity: Minor
Found in includes/logging/LogPager.php - About 3 hrs to fix

    LogPager has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class LogPager extends ReverseChronologicalPager {
    /** @var array Log types */
    private $types = [];

    /** @var string Events limited to those by performer when set */
    Severity: Minor
    Found in includes/logging/LogPager.php - About 3 hrs to fix

      Function limitTitle has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          private function limitTitle( $page, $pattern ) {
        if ( !$page instanceof PageReference ) {
            // NOTE: For some types of logs, the title may be something strange, like "User:#12345"!
            $page = Title::newFromText( $page );
            if ( !$page ) {
      Severity: Minor
      Found in includes/logging/LogPager.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 15 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct( $list, $types = [], $performer = '', $page = '',
        $pattern = false, $conds = [], $year = false, $month = false, $day = false,
        $tagFilter = '', $action = '', $logId = 0,
        LinkBatchFactory $linkBatchFactory = null,
        ActorNormalization $actorNormalization = null,
      Severity: Major
      Found in includes/logging/LogPager.php - About 1 hr to fix

        Method limitTitle has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function limitTitle( $page, $pattern ) {
        if ( !$page instanceof PageReference ) {
            // NOTE: For some types of logs, the title may be something strange, like "User:#12345"!
            $page = Title::newFromText( $page );
            if ( !$page ) {
        Severity: Minor
        Found in includes/logging/LogPager.php - About 1 hr to fix

          Function getQueryInfo has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getQueryInfo() {
        $queryBuilder = DatabaseLogEntry::newSelectQueryBuilder( $this->mDb )
            ->where( $this->mConds );

        # Add log_search table if there are conditions on it.
          Severity: Minor
          Found in includes/logging/LogPager.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getQueryInfo has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getQueryInfo() {
        $queryBuilder = DatabaseLogEntry::newSelectQueryBuilder( $this->mDb )
            ->where( $this->mConds );

        # Add log_search table if there are conditions on it.
          Severity: Minor
          Found in includes/logging/LogPager.php - About 1 hr to fix

            Function limitType has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private function limitType( $types ) {
        $restrictions = $this->getConfig()->get( MainConfigNames::LogRestrictions );
        // If $types is not an array, make it an array
        $types = ( $types === '' ) ? [] : (array)$types;
        // Don't even show header for private logs; don't recognize it...
            Severity: Minor
            Found in includes/logging/LogPager.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method limitType has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function limitType( $types ) {
        $restrictions = $this->getConfig()->get( MainConfigNames::LogRestrictions );
        // If $types is not an array, make it an array
        $types = ( $types === '' ) ? [] : (array)$types;
        // Don't even show header for private logs; don't recognize it...
            Severity: Minor
            Found in includes/logging/LogPager.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private function enforceActionRestrictions() {
        if ( $this->actionRestrictionsEnforced ) {
            return;
        }
        $this->actionRestrictionsEnforced = true;
              Severity: Major
              Found in includes/logging/LogPager.php and 1 other location - About 2 hrs to fix
              includes/logging/LogPager.php on lines 525..537

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private function enforcePerformerRestrictions() {
        // Same as enforceActionRestrictions(), except for _USER instead of _ACTION bits.
        if ( $this->performerRestrictionsEnforced ) {
            return;
        }
              Severity: Major
              Found in includes/logging/LogPager.php and 1 other location - About 2 hrs to fix
              includes/logging/LogPager.php on lines 509..520

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status