Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/logging/ManualLogEntry.php

Summary

Maintainability
C
1 day
Test Coverage

ManualLogEntry has 28 functions (exceeds 20 allowed). Consider refactoring.
Open

class ManualLogEntry extends LogEntryBase implements Taggable {
    /** @var string Type of log entry */
    protected $type;

    /** @var string Sub type of log entry */
Severity: Minor
Found in includes/logging/ManualLogEntry.php - About 3 hrs to fix

    Method insert has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function insert( IDatabase $dbw = null ) {
        $services = MediaWikiServices::getInstance();
        $dbw = $dbw ?: $services->getConnectionProvider()->getPrimaryDatabase();

        $this->timestamp ??= wfTimestampNow();
    Severity: Major
    Found in includes/logging/ManualLogEntry.php - About 2 hrs to fix

      Function publish has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function publish( $newId, $to = 'rcandudp' ) {
        $canAddTags = true;
        // FIXME: this code should be removed once all callers properly call publish()
        if ( $to === 'udp' && !$newId && !$this->getAssociatedRevId() ) {
            \MediaWiki\Logger\LoggerFactory::getInstance( 'logging' )->warning(
      Severity: Minor
      Found in includes/logging/ManualLogEntry.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method publish has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function publish( $newId, $to = 'rcandudp' ) {
        $canAddTags = true;
        // FIXME: this code should be removed once all callers properly call publish()
        if ( $to === 'udp' && !$newId && !$this->getAssociatedRevId() ) {
            \MediaWiki\Logger\LoggerFactory::getInstance( 'logging' )->warning(
      Severity: Minor
      Found in includes/logging/ManualLogEntry.php - About 1 hr to fix

        Function insert has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function insert( IDatabase $dbw = null ) {
        $services = MediaWikiServices::getInstance();
        $dbw = $dbw ?: $services->getConnectionProvider()->getPrimaryDatabase();

        $this->timestamp ??= wfTimestampNow();
        Severity: Minor
        Found in includes/logging/ManualLogEntry.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status