Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/mail/EmailUser.php

Summary

Maintainability
D
2 days
Test Coverage

Method sendEmailUnsafe has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function sendEmailUnsafe(
        UserEmailContact $target,
        string $subject,
        string $text,
        bool $CCMe,
Severity: Major
Found in includes/mail/EmailUser.php - About 3 hrs to fix

    Function sendEmailUnsafe has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function sendEmailUnsafe(
        UserEmailContact $target,
        string $subject,
        string $text,
        bool $CCMe,
    Severity: Minor
    Found in includes/mail/EmailUser.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File EmailUser.php has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/mail/EmailUser.php - About 2 hrs to fix

      Method validateTarget has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function validateTarget( UserEmailContact $target ): StatusValue {
        $targetIdentity = $target->getUser();

        if ( !$targetIdentity->getId() ) {
            return StatusValue::newFatal( 'emailnotarget' );
      Severity: Minor
      Found in includes/mail/EmailUser.php - About 1 hr to fix

        Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                ServiceOptions $options,
        HookContainer $hookContainer,
        UserOptionsLookup $userOptionsLookup,
        CentralIdLookup $centralIdLookup,
        UserFactory $userFactory,
        Severity: Major
        Found in includes/mail/EmailUser.php - About 1 hr to fix

          Function validateTarget has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function validateTarget( UserEmailContact $target ): StatusValue {
        $targetIdentity = $target->getUser();

        if ( !$targetIdentity->getId() ) {
            return StatusValue::newFatal( 'emailnotarget' );
          Severity: Minor
          Found in includes/mail/EmailUser.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method sendEmailUnsafe has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  UserEmailContact $target,
        string $subject,
        string $text,
        bool $CCMe,
        string $langCode
          Severity: Minor
          Found in includes/mail/EmailUser.php - About 35 mins to fix

            Avoid too many return statements within this method.
            Open

                    return StatusValue::newGood();
            Severity: Major
            Found in includes/mail/EmailUser.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $status;
              Severity: Major
              Found in includes/mail/EmailUser.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return $status;
                Severity: Major
                Found in includes/mail/EmailUser.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return StatusValue::newFatal( $error );
                  Severity: Major
                  Found in includes/mail/EmailUser.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return $status;
                    Severity: Major
                    Found in includes/mail/EmailUser.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return StatusValue::newFatal( 'nowikiemailtext' );
                      Severity: Major
                      Found in includes/mail/EmailUser.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return StatusValue::newGood();
                        Severity: Major
                        Found in includes/mail/EmailUser.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return $hookStatus;
                          Severity: Major
                          Found in includes/mail/EmailUser.php - About 30 mins to fix

                            There are no issues that match your filters.

                            Category
                            Status