includes/media/ExifBitmapHandler.php
Method convertMetadataVersion has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function convertMetadataVersion( $metadata, $version = 1 ) {
// basically flattens arrays.
$version = is_int( $version ) ? $version : (int)explode( ';', $version, 2 )[0];
if ( $version < 1 || $version >= 2 ) {
return $metadata;Method isFileMetadataValid has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function isFileMetadataValid( $image ) {
$showEXIF = MediaWikiServices::getInstance()->getMainConfig()->get( MainConfigNames::ShowEXIF );
if ( !$showEXIF ) {
# Metadata disabled and so an empty field is expected
return self::METADATA_GOOD;Function convertMetadataVersion has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
Open
public function convertMetadataVersion( $metadata, $version = 1 ) {
// basically flattens arrays.
$version = is_int( $version ) ? $version : (int)explode( ';', $version, 2 )[0];
if ( $version < 1 || $version >= 2 ) {
return $metadata;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function isFileMetadataValid has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
public function isFileMetadataValid( $image ) {
$showEXIF = MediaWikiServices::getInstance()->getMainConfig()->get( MainConfigNames::ShowEXIF );
if ( !$showEXIF ) {
# Metadata disabled and so an empty field is expected
return self::METADATA_GOOD;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
Open
return self::METADATA_GOOD;Avoid too many return statements within this method. Open
Open
return 0;Avoid too many return statements within this method. Open
Open
return self::METADATA_BAD;Avoid too many return statements within this method. Open
Open
return self::METADATA_COMPATIBLE;