Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/media/JpegHandler.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method swapICCProfile has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function swapICCProfile( $filepath, array $colorSpaces,
        array $oldProfileStrings, $profileFilepath
    ) {
        $exiftool = MediaWikiServices::getInstance()->getMainConfig()->get( MainConfigNames::Exiftool );
Severity: Minor
Found in includes/media/JpegHandler.php - About 1 hr to fix

    Function parseParamString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function parseParamString( $str ) {
        // $str contains "qlow-200px" or "200px" strings because thumb.php would strip the filename
        // first - check if the string begins with "qlow-", and if so, treat it as quality.
        // Pass the first portion, or the whole string if "qlow-" not found, to the parent
        // The parsing must match the makeParamString() above
    Severity: Minor
    Found in includes/media/JpegHandler.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return false;
    Severity: Major
    Found in includes/media/JpegHandler.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in includes/media/JpegHandler.php - About 30 mins to fix

        Function swapICCProfile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function swapICCProfile( $filepath, array $colorSpaces,
        array $oldProfileStrings, $profileFilepath
    ) {
        $exiftool = MediaWikiServices::getInstance()->getMainConfig()->get( MainConfigNames::Exiftool );
        Severity: Minor
        Found in includes/media/JpegHandler.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status