Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/page/PageProps.php

Summary

Maintainability
C
1 day
Test Coverage

Function getGoodIDs has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    private function getGoodIDs( $titles ) {
        $result = [];
        if ( is_iterable( $titles ) ) {
            if ( $titles instanceof TitleArrayFromResult ||
                ( is_array( $titles ) && reset( $titles ) instanceof Title
Severity: Minor
Found in includes/page/PageProps.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getProperties has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function getProperties( $titles, $propertyNames ) {
        if ( is_array( $propertyNames ) ) {
            $gotArray = true;
        } else {
            $propertyNames = [ $propertyNames ];
Severity: Minor
Found in includes/page/PageProps.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getAllProperties has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAllProperties( $titles ) {
        $values = [];
        $goodIDs = $this->getGoodIDs( $titles );
        $queryIDs = [];
        foreach ( $goodIDs as $pageID ) {
Severity: Minor
Found in includes/page/PageProps.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getProperties has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getProperties( $titles, $propertyNames ) {
        if ( is_array( $propertyNames ) ) {
            $gotArray = true;
        } else {
            $propertyNames = [ $propertyNames ];
Severity: Minor
Found in includes/page/PageProps.php - About 1 hr to fix

    Method getAllProperties has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getAllProperties( $titles ) {
        $values = [];
        $goodIDs = $this->getGoodIDs( $titles );
        $queryIDs = [];
        foreach ( $goodIDs as $pageID ) {
    Severity: Minor
    Found in includes/page/PageProps.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status