Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/page/PageStore.php

Summary

Maintainability
B
6 hrs
Test Coverage

File PageStore.php has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace MediaWiki\Page;

use EmptyIterator;
Severity: Minor
Found in includes/page/PageStore.php - About 2 hrs to fix

    Method getPageByNameViaLinkCache has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getPageByNameViaLinkCache(
        int $namespace,
        string $dbKey,
        int $queryFlags = IDBAccessObject::READ_NORMAL
    ): ?ExistingPageRecord {
    Severity: Minor
    Found in includes/page/PageStore.php - About 1 hr to fix

      Function getPageByNameViaLinkCache has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getPageByNameViaLinkCache(
        int $namespace,
        string $dbKey,
        int $queryFlags = IDBAccessObject::READ_NORMAL
    ): ?ExistingPageRecord {
      Severity: Minor
      Found in includes/page/PageStore.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ServiceOptions $options,
        ILoadBalancer $dbLoadBalancer,
        NamespaceInfo $namespaceInfo,
        TitleParser $titleParser,
        ?LinkCache $linkCache,
      Severity: Major
      Found in includes/page/PageStore.php - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status