Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/page/UndeletePage.php

Summary

Maintainability
F
3 days
Test Coverage

File UndeletePage.php has 438 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/page/UndeletePage.php - About 6 hrs to fix

    Method undeleteRevisions has 149 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function undeleteRevisions( ProperPageIdentity $page, array $timestamps, string $comment ): StatusValue {
        if ( $this->readOnlyMode->isReadOnly() ) {
            throw new ReadOnlyError();
        }
    Severity: Major
    Found in includes/page/UndeletePage.php - About 5 hrs to fix

      Function undeleteRevisions has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

          private function undeleteRevisions( ProperPageIdentity $page, array $timestamps, string $comment ): StatusValue {
        if ( $this->readOnlyMode->isReadOnly() ) {
            throw new ReadOnlyError();
        }
      Severity: Minor
      Found in includes/page/UndeletePage.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function undeleteUnsafe has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

          public function undeleteUnsafe( string $comment ): StatusValue {
        $hookStatus = $this->runPreUndeleteHook( $comment );
        if ( !$hookStatus->isGood() ) {
            return $hookStatus;
        }
      Severity: Minor
      Found in includes/page/UndeletePage.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method undeleteUnsafe has 89 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function undeleteUnsafe( string $comment ): StatusValue {
        $hookStatus = $this->runPreUndeleteHook( $comment );
        if ( !$hookStatus->isGood() ) {
            return $hookStatus;
        }
      Severity: Major
      Found in includes/page/UndeletePage.php - About 3 hrs to fix

        Method __construct has 15 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                HookContainer $hookContainer,
        JobQueueGroup $jobQueueGroup,
        IConnectionProvider $dbProvider,
        ReadOnlyMode $readOnlyMode,
        RepoGroup $repoGroup,
        Severity: Major
        Found in includes/page/UndeletePage.php - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                  return $status;
          Severity: Major
          Found in includes/page/UndeletePage.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $resStatus;
            Severity: Major
            Found in includes/page/UndeletePage.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $resStatus;
              Severity: Major
              Found in includes/page/UndeletePage.php - About 30 mins to fix

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    public function __construct(
        HookContainer $hookContainer,
        JobQueueGroup $jobQueueGroup,
        IConnectionProvider $dbProvider,
        ReadOnlyMode $readOnlyMode,
                Severity: Major
                Found in includes/page/UndeletePage.php and 3 other locations - About 1 hr to fix
                includes/Permissions/PermissionManager.php on lines 283..316
                includes/auth/AuthManager.php on lines 261..295
                includes/specials/SpecialUndelete.php on lines 169..202

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status