Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/parser/PPFrame_Hash.php

Summary

Maintainability
F
5 days
Test Coverage

Function expand has a Cognitive Complexity of 100 (exceeds 5 allowed). Consider refactoring.
Open

    public function expand( $root, $flags = 0 ) {
        static $expansionDepth = 0;
        if ( is_string( $root ) ) {
            return $root;
        }
Severity: Minor
Found in includes/parser/PPFrame_Hash.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method expand has 198 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function expand( $root, $flags = 0 ) {
        static $expansionDepth = 0;
        if ( is_string( $root ) ) {
            return $root;
        }
Severity: Major
Found in includes/parser/PPFrame_Hash.php - About 7 hrs to fix

    File PPFrame_Hash.php has 408 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/parser/PPFrame_Hash.php - About 5 hrs to fix

      Function newChild has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public function newChild( $args = false, $title = false, $indexOffset = 0 ) {
        $namedArgs = [];
        $numberedArgs = [];
        if ( $title === false ) {
            $title = $this->title;
      Severity: Minor
      Found in includes/parser/PPFrame_Hash.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      PPFrame_Hash has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class PPFrame_Hash implements PPFrame {

    /**
     * @var Parser
     */
      Severity: Minor
      Found in includes/parser/PPFrame_Hash.php - About 2 hrs to fix

        Method newChild has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function newChild( $args = false, $title = false, $indexOffset = 0 ) {
        $namedArgs = [];
        $numberedArgs = [];
        if ( $title === false ) {
            $title = $this->title;
        Severity: Minor
        Found in includes/parser/PPFrame_Hash.php - About 1 hr to fix

          Function virtualImplode has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function virtualImplode( $sep, ...$args ) {
        $out = [];
        $first = true;

        foreach ( $args as $root ) {
          Severity: Minor
          Found in includes/parser/PPFrame_Hash.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function implodeWithFlags has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function implodeWithFlags( $sep, $flags, ...$args ) {
        $first = true;
        $s = '';
        foreach ( $args as $root ) {
            if ( $root instanceof PPNode_Hash_Array ) {
          Severity: Minor
          Found in includes/parser/PPFrame_Hash.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function virtualBracketedImplode has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function virtualBracketedImplode( $start, $sep, $end, ...$args ) {
        $out = [ $start ];
        $first = true;

        foreach ( $args as $root ) {
          Severity: Minor
          Found in includes/parser/PPFrame_Hash.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function implode has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function implode( $sep, ...$args ) {
        $first = true;
        $s = '';
        foreach ( $args as $root ) {
            if ( $root instanceof PPNode_Hash_Array ) {
          Severity: Minor
          Found in includes/parser/PPFrame_Hash.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                          if ( ( $this->parser->ot['html']
                    || ( $this->parser->ot['pre'] && $this->parser->mOptions->getRemoveComments() )
                    || ( $flags & PPFrame::STRIP_COMMENTS )
                    ) && !( $flags & PPFrame::RECOVER_COMMENTS )
                ) {
          Severity: Major
          Found in includes/parser/PPFrame_Hash.php - About 40 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        } elseif ( $contextName === 'tplarg' ) {
                # Triple-brace expansion
                $bits = PPNode_Hash_Tree::splitRawTemplate( $contextChildren );
                if ( $flags & PPFrame::NO_ARGS ) {
                    $newIterator = $this->virtualBracketedImplode(
            Severity: Major
            Found in includes/parser/PPFrame_Hash.php and 1 other location - About 2 hrs to fix
            includes/parser/PPFrame_Hash.php on lines 265..282

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 124.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        } elseif ( $contextName === 'template' ) {
                # Double-brace expansion
                $bits = PPNode_Hash_Tree::splitRawTemplate( $contextChildren );
                if ( $flags & PPFrame::NO_TEMPLATES ) {
                    $newIterator = $this->virtualBracketedImplode(
            Severity: Major
            Found in includes/parser/PPFrame_Hash.php and 1 other location - About 2 hrs to fix
            includes/parser/PPFrame_Hash.php on lines 282..299

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 124.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ( $args as $root ) {
            if ( $root instanceof PPNode_Hash_Array ) {
                $root = $root->value;
            }
            if ( !is_array( $root ) ) {
            Severity: Minor
            Found in includes/parser/PPFrame_Hash.php and 1 other location - About 35 mins to fix
            includes/parser/PPFrame_Hash.php on lines 498..513

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ( $args as $root ) {
            if ( $root instanceof PPNode_Hash_Array ) {
                $root = $root->value;
            }
            if ( !is_array( $root ) ) {
            Severity: Minor
            Found in includes/parser/PPFrame_Hash.php and 1 other location - About 35 mins to fix
            includes/parser/PPFrame_Hash.php on lines 466..481

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status