Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/parser/Parsoid/LanguageVariantConverter.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method convertPageBundleVariant has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function convertPageBundleVariant(
        PageBundle $pageBundle,
        Bcp47Code $targetVariant,
        ?Bcp47Code $sourceVariant = null
    ): PageBundle {
Severity: Minor
Found in includes/parser/Parsoid/LanguageVariantConverter.php - About 1 hr to fix

    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            PageIdentity $pageIdentity,
        PageConfigFactory $pageConfigFactory,
        Parsoid $parsoid,
        SiteConfig $siteConfig,
        TitleFactory $titleFactory,
    Severity: Major
    Found in includes/parser/Parsoid/LanguageVariantConverter.php - About 50 mins to fix

      Function getBaseAndSourceLanguage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getBaseAndSourceLanguage( PageBundle $pageBundle, ?Bcp47Code $sourceLanguage ): array {
        // Try to determine the language code associated with the content of the page.
        // The result may be a variant code.
        $baseLanguage = $this->getPageLanguage( $pageBundle, $sourceLanguage );
      Severity: Minor
      Found in includes/parser/Parsoid/LanguageVariantConverter.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function convertPageBundleVariant has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function convertPageBundleVariant(
        PageBundle $pageBundle,
        Bcp47Code $targetVariant,
        ?Bcp47Code $sourceVariant = null
    ): PageBundle {
      Severity: Minor
      Found in includes/parser/Parsoid/LanguageVariantConverter.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $this->pageTitle->getPageLanguage();
      Severity: Major
      Found in includes/parser/Parsoid/LanguageVariantConverter.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status