Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/parser/Parsoid/ParsoidParser.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method genParserOutput has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function genParserOutput(
        PageConfig $pageConfig, ParserOptions $options
    ): ParserOutput {
        $parserOutput = new ParserOutput();
Severity: Minor
Found in includes/parser/Parsoid/ParsoidParser.php - About 1 hr to fix

    Method parse has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function parse(
        string $text, PageReference $page, ParserOptions $options,
        bool $linestart = true, bool $clearState = true, ?int $revId = null
    ): ParserOutput {
        Assert::invariant( $linestart, '$linestart=false is not yet supported' );
    Severity: Minor
    Found in includes/parser/Parsoid/ParsoidParser.php - About 1 hr to fix

      Method parse has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $text, PageReference $page, ParserOptions $options,
        bool $linestart = true, bool $clearState = true, ?int $revId = null
      Severity: Minor
      Found in includes/parser/Parsoid/ParsoidParser.php - About 45 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Parsoid $parsoid,
        PageConfigFactory $pageConfigFactory,
        LanguageConverterFactory $languageConverterFactory,
        ParserFactory $legacyParserFactory,
        GlobalIdGenerator $globalIdGenerator
        Severity: Minor
        Found in includes/parser/Parsoid/ParsoidParser.php - About 35 mins to fix

          Function genParserOutput has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function genParserOutput(
        PageConfig $pageConfig, ParserOptions $options
    ): ParserOutput {
        $parserOutput = new ParserOutput();
          Severity: Minor
          Found in includes/parser/Parsoid/ParsoidParser.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status