Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/parser/RevisionOutputCache.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method save has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function save(
        ParserOutput $output,
        RevisionRecord $revision,
        ParserOptions $parserOptions,
        string $cacheTime = null
Severity: Minor
Found in includes/parser/RevisionOutputCache.php - About 1 hr to fix

    Method get has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get( RevisionRecord $revision, ParserOptions $parserOptions ) {
        if ( $this->cacheExpiry <= 0 ) {
            // disabled
            return false;
        }
    Severity: Minor
    Found in includes/parser/RevisionOutputCache.php - About 1 hr to fix

      Function save has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function save(
        ParserOutput $output,
        RevisionRecord $revision,
        ParserOptions $parserOptions,
        string $cacheTime = null
      Severity: Minor
      Found in includes/parser/RevisionOutputCache.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $name,
        WANObjectCache $cache,
        int $cacheExpiry,
        string $cacheEpoch,
        JsonCodec $jsonCodec,
      Severity: Major
      Found in includes/parser/RevisionOutputCache.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in includes/parser/RevisionOutputCache.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $output;
          Severity: Major
          Found in includes/parser/RevisionOutputCache.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status