includes/recentchanges/RecentChangesUpdateJob.php
Method updateActiveUsers
has 94 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
protected function updateActiveUsers() {
$activeUserDays = MediaWikiServices::getInstance()->getMainConfig()->get(
MainConfigNames::ActiveUserDays );
// Users that made edits at least this many days ago are "active"
Method purgeExpiredRows
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
protected function purgeExpiredRows() {
$services = MediaWikiServices::getInstance();
$rcMaxAge = $services->getMainConfig()->get(
MainConfigNames::RCMaxAge );
$updateRowsPerQuery = $services->getMainConfig()->get(
Function updateActiveUsers
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function updateActiveUsers() {
$activeUserDays = MediaWikiServices::getInstance()->getMainConfig()->get(
MainConfigNames::ActiveUserDays );
// Users that made edits at least this many days ago are "active"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function purgeExpiredRows
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function purgeExpiredRows() {
$services = MediaWikiServices::getInstance();
$rcMaxAge = $services->getMainConfig()->get(
MainConfigNames::RCMaxAge );
$updateRowsPerQuery = $services->getMainConfig()->get(
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"