Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/site/DBSiteStore.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method saveSites has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function saveSites( array $sites ) {
        if ( !$sites ) {
            return true;
        }
Severity: Major
Found in includes/site/DBSiteStore.php - About 2 hrs to fix

    Method loadSites has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function loadSites() {
        $this->sites = new SiteList();

        $dbr = $this->dbProvider->getReplicaDatabase();
    Severity: Minor
    Found in includes/site/DBSiteStore.php - About 1 hr to fix

      Function saveSites has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function saveSites( array $sites ) {
        if ( !$sites ) {
            return true;
        }
      Severity: Minor
      Found in includes/site/DBSiteStore.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status