Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialActiveUsers.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method buildForm has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function buildForm() {
        $groups = $this->userGroupManager->listAllGroups();

        $options = [];
        $lang = $this->getLanguage();
Severity: Minor
Found in includes/specials/SpecialActiveUsers.php - About 1 hr to fix

    Method execute has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute( $par ) {
        $out = $this->getOutput();

        $this->setHeaders();
        $this->outputHeader();
    Severity: Minor
    Found in includes/specials/SpecialActiveUsers.php - About 1 hr to fix

      Method getIntroText has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getIntroText() {
        $days = $this->getConfig()->get( MainConfigNames::ActiveUserDays );

        $intro = $this->msg( 'activeusers-intro' )->numParams( $days )->parse();
      Severity: Minor
      Found in includes/specials/SpecialActiveUsers.php - About 1 hr to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                LinkBatchFactory $linkBatchFactory,
        IConnectionProvider $dbProvider,
        UserGroupManager $userGroupManager,
        UserIdentityLookup $userIdentityLookup,
        HideUserUtils $hideUserUtils
        Severity: Minor
        Found in includes/specials/SpecialActiveUsers.php - About 35 mins to fix

          Function getIntroText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getIntroText() {
        $days = $this->getConfig()->get( MainConfigNames::ActiveUserDays );

        $intro = $this->msg( 'activeusers-intro' )->numParams( $days )->parse();
          Severity: Minor
          Found in includes/specials/SpecialActiveUsers.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function __construct(
        LinkBatchFactory $linkBatchFactory,
        IConnectionProvider $dbProvider,
        UserGroupManager $userGroupManager,
        UserIdentityLookup $userIdentityLookup,
          Severity: Major
          Found in includes/specials/SpecialActiveUsers.php and 3 other locations - About 40 mins to fix
          includes/specials/SpecialEmailUser.php on lines 64..77
          includes/specials/SpecialListUsers.php on lines 57..70
          includes/specials/SpecialLog.php on lines 72..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status