Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialBookSources.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function isValidISBN has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public static function isValidISBN( $isbn ) {
        $isbn = self::cleanIsbn( $isbn );
        $sum = 0;
        if ( strlen( $isbn ) == 13 ) {
            for ( $i = 0; $i < 12; $i++ ) {
Severity: Minor
Found in includes/specials/SpecialBookSources.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method isValidISBN has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function isValidISBN( $isbn ) {
        $isbn = self::cleanIsbn( $isbn );
        $sum = 0;
        if ( strlen( $isbn ) == 13 ) {
            for ( $i = 0; $i < 12; $i++ ) {
Severity: Minor
Found in includes/specials/SpecialBookSources.php - About 1 hr to fix

    Method showList has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function showList( $isbn ) {
        $out = $this->getOutput();

        $isbn = self::cleanIsbn( $isbn );
        # Hook to allow extensions to insert additional HTML,
    Severity: Minor
    Found in includes/specials/SpecialBookSources.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in includes/specials/SpecialBookSources.php - About 30 mins to fix

        Function showList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function showList( $isbn ) {
        $out = $this->getOutput();

        $isbn = self::cleanIsbn( $isbn );
        # Hook to allow extensions to insert additional HTML,
        Severity: Minor
        Found in includes/specials/SpecialBookSources.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status