Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialListGroupRights.php

Summary

Maintainability
D
1 day
Test Coverage

Method execute has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute( $par ) {
        $this->setHeaders();
        $this->outputHeader();

        $out = $this->getOutput();
Severity: Major
Found in includes/specials/SpecialListGroupRights.php - About 3 hrs to fix

    Method outputNamespaceProtectionInfo has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function outputNamespaceProtectionInfo() {
        $out = $this->getOutput();
        $namespaceProtection = $this->getConfig()->get( MainConfigNames::NamespaceProtection );

        if ( count( $namespaceProtection ) == 0 ) {
    Severity: Major
    Found in includes/specials/SpecialListGroupRights.php - About 2 hrs to fix

      Function formatPermissions has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          private function formatPermissions( $permissions, $revoke, $add, $remove, $addSelf, $removeSelf ) {
        $r = [];
        foreach ( $permissions as $permission ) {
            // show as granted only if it isn't revoked to prevent duplicate display of permissions
            if ( !isset( $revoke[$permission] ) || !$revoke[$permission] ) {
      Severity: Minor
      Found in includes/specials/SpecialListGroupRights.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method formatPermissions has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function formatPermissions( $permissions, $revoke, $add, $remove, $addSelf, $removeSelf ) {
        $r = [];
        foreach ( $permissions as $permission ) {
            // show as granted only if it isn't revoked to prevent duplicate display of permissions
            if ( !isset( $revoke[$permission] ) || !$revoke[$permission] ) {
      Severity: Minor
      Found in includes/specials/SpecialListGroupRights.php - About 2 hrs to fix

        Function outputNamespaceProtectionInfo has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            private function outputNamespaceProtectionInfo() {
        $out = $this->getOutput();
        $namespaceProtection = $this->getConfig()->get( MainConfigNames::NamespaceProtection );

        if ( count( $namespaceProtection ) == 0 ) {
        Severity: Minor
        Found in includes/specials/SpecialListGroupRights.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function execute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function execute( $par ) {
        $this->setHeaders();
        $this->outputHeader();

        $out = $this->getOutput();
        Severity: Minor
        Found in includes/specials/SpecialListGroupRights.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method formatPermissions has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function formatPermissions( $permissions, $revoke, $add, $remove, $addSelf, $removeSelf ) {
        Severity: Minor
        Found in includes/specials/SpecialListGroupRights.php - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status