Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialLog.php

Summary

Maintainability
D
2 days
Test Coverage

Function execute has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute( $par ) {
        $this->setHeaders();
        $this->outputHeader();
        $out = $this->getOutput();
        $out->addModules( 'mediawiki.userSuggest' );
Severity: Minor
Found in includes/specials/SpecialLog.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute( $par ) {
        $this->setHeaders();
        $this->outputHeader();
        $out = $this->getOutput();
        $out->addModules( 'mediawiki.userSuggest' );
Severity: Major
Found in includes/specials/SpecialLog.php - About 3 hrs to fix

    File SpecialLog.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/specials/SpecialLog.php - About 2 hrs to fix

      Method show has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function show( FormOptions $opts, array $extraConds ) {
        # Create a LogPager item to get the results and a LogEventsList item to format them...
        $loglist = new LogEventsList(
            $this->getContext(),
            $this->getLinkRenderer(),
      Severity: Major
      Found in includes/specials/SpecialLog.php - About 2 hrs to fix

        Method getActionButtons has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getActionButtons( $formcontents ) {
        $canRevDelete = $this->getAuthority()
            ->isAllowedAll( 'deletedhistory', 'deletelogentry' );
        $showTagEditUI = ChangeTags::showTagEditingUI( $this->getAuthority() );
        # If the user doesn't have the ability to delete log entries nor edit tags,
        Severity: Minor
        Found in includes/specials/SpecialLog.php - About 1 hr to fix

          Function show has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private function show( FormOptions $opts, array $extraConds ) {
        # Create a LogPager item to get the results and a LogEventsList item to format them...
        $loglist = new LogEventsList(
            $this->getContext(),
            $this->getLinkRenderer(),
          Severity: Minor
          Found in includes/specials/SpecialLog.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  LinkBatchFactory $linkBatchFactory,
        IConnectionProvider $dbProvider,
        ActorNormalization $actorNormalization,
        UserIdentityLookup $userIdentityLookup,
        UserNameUtils $userNameUtils
          Severity: Minor
          Found in includes/specials/SpecialLog.php - About 35 mins to fix

            Function parseParams has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function parseParams( string $par ) {
        # Get parameters
        $parms = explode( '/', $par, 2 );
        $symsForAll = [ '*', 'all' ];
        if ( $parms[0] !== '' &&
            Severity: Minor
            Found in includes/specials/SpecialLog.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public function __construct(
        LinkBatchFactory $linkBatchFactory,
        IConnectionProvider $dbProvider,
        ActorNormalization $actorNormalization,
        UserIdentityLookup $userIdentityLookup,
            Severity: Major
            Found in includes/specials/SpecialLog.php and 3 other locations - About 40 mins to fix
            includes/specials/SpecialActiveUsers.php on lines 55..68
            includes/specials/SpecialEmailUser.php on lines 61..74
            includes/specials/SpecialListUsers.php on lines 56..69

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 94.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status