Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialMergeHistory.php

Summary

Maintainability
C
1 day
Test Coverage

Method showHistory has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function showHistory() {
        # List all stored revisions
        $revisions = new MergeHistoryPager(
            $this->getContext(),
            $this->getLinkRenderer(),
Severity: Major
Found in includes/specials/SpecialMergeHistory.php - About 3 hrs to fix

    File SpecialMergeHistory.php has 288 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/specials/SpecialMergeHistory.php - About 2 hrs to fix

      Method showMergeForm has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function showMergeForm() {
        $out = $this->getOutput();
        $out->addWikiMsg( 'mergehistory-header' );

        $fields = [
      Severity: Minor
      Found in includes/specials/SpecialMergeHistory.php - About 1 hr to fix

        Method execute has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function execute( $par ) {
        $this->useTransactionalTimeLimit();

        $this->checkPermissions();
        $this->checkReadOnly();
        Severity: Minor
        Found in includes/specials/SpecialMergeHistory.php - About 1 hr to fix

          Method merge has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function merge() {
        # Get the titles directly from the IDs, in case the target page params
        # were spoofed. The queries are done based on the IDs, so it's best to
        # keep it consistent...
        $targetTitle = Title::newFromID( $this->mTargetID );
          Severity: Minor
          Found in includes/specials/SpecialMergeHistory.php - About 1 hr to fix

            Function execute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function execute( $par ) {
        $this->useTransactionalTimeLimit();

        $this->checkPermissions();
        $this->checkReadOnly();
            Severity: Minor
            Found in includes/specials/SpecialMergeHistory.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    MergeHistoryFactory $mergeHistoryFactory,
        LinkBatchFactory $linkBatchFactory,
        IConnectionProvider $dbProvider,
        RevisionStore $revisionStore,
        CommentFormatter $commentFormatter
            Severity: Minor
            Found in includes/specials/SpecialMergeHistory.php - About 35 mins to fix

              There are no issues that match your filters.

              Category
              Status